[
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108462#comment-16108462
]
Pranav Maniar edited comment on KAFKA-1944 at 8/1/17 6:39 AM:
--------------------------------------------------------------
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
{code}
log.cleaner.backoff.ms
log.cleaner.delete.retention.ms
log.cleaner.min.compaction.lag.ms
log.cleaner.threads
...
{code}
was (Author: pranav.maniar):
It seems that there are agreement/disagreement related to change...
So should I create KIP or first we discuss it over JIRA/mailing list ?
Also, what about other cleaner configs apart from {{log.cleaner.enable}} ? Does
any of the other cleaner config also requires renaming ? E.g.
{code}
log.cleaner.backoff.ms
log.cleaner.delete.retention.ms
log.cleaner.min.compaction.lag.ms
log.cleaner.threads
{code}
> Rename LogCleaner and related classes to LogCompactor
> -----------------------------------------------------
>
> Key: KAFKA-1944
> URL: https://issues.apache.org/jira/browse/KAFKA-1944
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Pranav Maniar
> Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor.
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and
> metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
