[ 
https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105845#comment-16105845
 ] 

Jason Gustafson commented on KAFKA-1944:
----------------------------------------

The name LogCleaner is somewhat entrenched. If this is just a matter of 
renaming {{LogCleaner}} to {{LogCompactor}}, that could be done in a MINOR PR, 
but that probably only makes sense if we change the configuration 
{{log.cleaner.enable}} as well. On the other hand, since we have changed its 
default value to true and since two key components now depend on it (i.e. the 
new consumer and the transactional producer), maybe we should consider 
deprecating the config instead?

> Rename LogCleaner and related classes to LogCompactor
> -----------------------------------------------------
>
>                 Key: KAFKA-1944
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1944
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Aravind Selvan
>              Labels: newbie
>
> Following a mailing list discussion:
> "the name LogCleaner is seriously misleading. Its more of a log compactor. 
> Deleting old logs happens elsewhere from what I've seen."
> Note that this may require renaming related classes, objects, configs and 
> metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to