[
https://issues.apache.org/jira/browse/KAFKA-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091544#comment-16091544
]
ASF GitHub Bot commented on KAFKA-5499:
---------------------------------------
GitHub user enothereska opened a pull request:
https://github.com/apache/kafka/pull/3545
KAFKA-5499: Minor cleanup of commit code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enothereska/kafka KAFKA-5499-commit-exceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3545
----
commit eb045209b49354cae182291d7a294e77e07d8659
Author: Eno Thereska <[email protected]>
Date: 2017-07-18T13:22:58Z
Minor cleanup
----
> Double check how we handle exceptions when commits fail
> -------------------------------------------------------
>
> Key: KAFKA-5499
> URL: https://issues.apache.org/jira/browse/KAFKA-5499
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Reporter: Eno Thereska
> Assignee: Eno Thereska
> Fix For: 0.11.1.0
>
>
> When a task does a lot of processing in-between calls to poll() it happens
> that it might miss a rebalance. It can find that out once it tries to
> commit() since it will get an exception. Double check what is supposed to
> happen on such an exception, e.g., should the thread fail, or should it
> continue?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
