[ 
https://issues.apache.org/jira/browse/ARROW-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657441#comment-17657441
 ] 

Rok Mihevc commented on ARROW-407:
----------------------------------

This issue has been migrated to [issue 
#16056|https://github.com/apache/arrow/issues/16056] on GitHub. Please see the 
[migration documentation|https://github.com/apache/arrow/issues/14542] for 
further details.

> BitVector.copyFromSafe() should re-allocate if necessary instead of returning 
> false
> -----------------------------------------------------------------------------------
>
>                 Key: ARROW-407
>                 URL: https://issues.apache.org/jira/browse/ARROW-407
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java
>            Reporter: Abdel Hakim Deneche
>            Assignee: Abdel Hakim Deneche
>            Priority: Major
>             Fix For: 0.7.0
>
>
> Current implementation:
> {code}
> public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
>     if (outIndex >= this.getValueCapacity()) {
>       decrementAllocationMonitor();
>       return false;
>     }
>     copyFrom(inIndex, outIndex, from);
>     return true;
>   }
> {code}
> doesn't match the expectation from "safe" methods. The method should try to 
> re-allocate if it's running out of space instead of returning false



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to