Looks good to me - doing some fairly involved things but it reads clearly to me. I presume the "mail" DSL function didn't do what you want so you had to use the "step" version of it?
If you find you have many flows that do similar things you could make your own DSL functions to share for the freebsd instance. I like it! Nicely done. On Wednesday, December 23, 2015 at 9:37:00 AM UTC+11, Craig Rodrigues wrote: > > Hi, > > I am making some serious efforts to convert my existing Jenkins jobs > to use workflow. My first attempt is here: > > > https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/build-test.groovy > > The script calls several helper scripts, but overall what it is trying to > do is: > > 1. Builds the FreeBSD src tree. > 2. Run the Warnings plugin over the compiler output to detect warnings > 3. Creates a VM disk image which can boot in bhyve. > 4. Boots the VM disk image in bhyve > 5. Runs the FreeBSD test suite in the VM > 6. Take the JUnit test output and add it to the test report viewer > > I have a flow running now: > https://jenkins.freebsd.org/job/HEAD_Build_and_Test/32/flowGraphTable/ > > Can someone review my script and provide feedback, on any obvious > things I have done wrong, or any possible ways to optimize it? > > Providing feedback on this list or GitHub is fine, whatever is more > convenient. > > Thanks. > > -- > Craig > > -- You received this message because you are subscribed to the Google Groups "Jenkins Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-users/01f7c1a6-80aa-41ce-bb91-64d5a1e3928d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
