[JIRA] [xfpanel-plugin] (JENKINS-20768) Comparison method violates its general contract exception

[tomaszbech...@gmail.com (JIRA)]

Title: Message Title

Tomasz Bech commented on JENKINS-20768   Re: Comparison method violates its general contract exception This new algorithm with throwing exception is pretty nasty: sorting violatile data will most likely throw exception. Here during sort the 'status' of the job can change so even having perfect comparison sort can fail. Simple test below which simulates that data used in sort changes 'outside' - fails most of the time. public void testSort2() { List<A> list = new ArrayList<A>(); for (int i = 0; i < 1000; i++) { A a1 = new A(); a1.setValue((int) (Math.random() * 100)); list.add(a1); } Collections.sort(list, new Comparator<A>() { @Override public int compare(A o1, A o2) { o2.setValue((int) (Math.random() * 100)); //HERE value has changed 'outside' if (o1.getValue() > o2.getValue()) { return 1; } if (o1.getValue() < o2.getValue()) { return -1; } return 0; } }); } So to make it 100% we should have collect all values before sort (priority, lastBuild, isBuilding, CompletionTimestamp) - not worth much such refactoring. I suggest to stick with '-Djava.util.Arrays.useLegacyMergeSort=true' Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.