[JIRA] [postbuildscript-plugin] (JENKINS-28825) Confusing error message when leaving script path empty

[aam.gerrit...@gmail.com (JIRA)]

Title: Message Title

Albert Gerritsen created an issue   Jenkins / JENKINS-28825 Confusing error message when leaving script path empty Issue Type: Bug Assignee: Gregory Boissinot Components: postbuildscript-plugin Created: 10/Jun/15 8:50 AM Environment: Jenkins 1.613, Post-Build Script Plug-in 0.17 Priority: Minor Reporter: Albert Gerritsen When configuring the post build action it is very easy to accidentally have an empty reference to a script. When executing the build task, it will fail with the error message: "Error to resolve environment variables" Which is misleading because the problem is the empty file path. I briefly checked ScriptExecutor.java and noticed the plugin does check whether or not the file exists and then gives a sensible error message. But it does not explicitly check whether or not the path is actually a file. In this case it will be a directory and that is why the failure happens later when resolving the environment variables. My suggestions would be the following: In getFilePath explicitly check that the path is a file When configuring the action, present a warning when the field is empty Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.