[JIRA] [ws-cleanup-plugin] (JENKINS-12783) Delete workspace before build starts ignores Exlude patterns (for directories)

[david.w.acker...@gmail.com (JIRA)]

Title: Message Title

David Ackerman commented on JENKINS-12783   Re: Delete workspace before build starts ignores Exlude patterns (for directories) I had the same issue, and I think I figured out what was going wrong (after cloning the repo and adding enough logging statements). Excluding (not-deleting) everything under a toplevel directory works fine, i.e "toplevel/*" excludes everything under the folder "$WORKSPACE/toplevel". However, excluding something in a subdirectory does not work - i.e. "toplevel/asubdir/*" ends up deleting everything. This happens when you have "apply pattern also on directories" turned on. The reason is that DirectoryScanner will find directories to delete that might be parents of files that you've excluded, but the plugin deletes those folders recursively (i.e. rm -rf). The way to fix this is to add "toplevel" explicitly as an exclude to prevent it from deleting the parent directory as well. The reason I have the directories checkbox turned on is because I don't want the ".git" directory (or any extra directories) lying around and confusing jenkins when it builds the next time. My project looks something like this (in a multi-module maven project, where node_modules/ resides in several subdirectories). folder-1 node_modules folder-2 node_modules folder-3 folder-4 node_modules My Configuration looks like this: EXCLUDE */node_modules/* EXCLUDE folder-1 EXCLUDE folder-2 EXCLUDE folder-4 And that seems to work as expected. It seems like the plugin needs to be more careful about the directories it deletes recursively - it needs to avoid deleting a parent that would delete excluded files (or maybe just do "rm" instead of "rm -r" so it won't delete the directory if it has otherwise excluded files in it). I would offer to create a patch, but my Intellij doesn't seem to be resolving dependencies in the project properly (although maven commands work fine), and I am not sure what others would consider the ideal behavior. At the very least, I think more documentation in the plugin help and/or plugin page would save people a lot of time. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.