[JIRA] [core] (JENKINS-25601) JDK9 with jigsaw file layer is not detected as valid JDK

[dan...@beckweb.net (JIRA)]

Daniel Beck commented on JENKINS-25601 JDK9 with jigsaw file layer is not detected as valid JDK It started out with the tools.jar check (commit lost to history), then added a Mac-specific test in https://github.com/jenkinsci/jenkins/commit/d1b27237707e97095657bd1ef2f0facaf84f32e0 that was modified for JENKINS-533 in https://github.com/jenkinsci/jenkins/commit/aef102cb727fe65305a5f66fc5949096c9a5b473. It's possible tools.jar was checked because it's easier than platform-dependent javac binary names. Given that section: All other files and directories in the lib directory must be treated as private implementation details of the run-time system. They are not intended for external use and their names, format, and content will be subject to change without notice. The only sensible solution seems to be to check for bin/javac and bin\javac.exe and if neither exists, provide the warning. Keep the existing two checks for compatibility in case there are other javac names on some platforms, they shouldn't hurt anything.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.