|
Currently in the P4ChangeSet.store(changelogFile, changes);
step the changelog.xml file is written.
This only stores the change numbers.
e.g.
<changelog>
<entry>
<changenumber>77091</changenumber>
</entry>
</changelog>
Every time a REST call or the GUI requests this XML information gets loaded via SAX and then p4 calls are made to get the info.
This means the REST calls are SLOW , the same with the GUI.
Expecially if there are lots of changes or the P4 server is very busy.
I tested some code at add the change details to the changelog file:
e.g.
<changelog>
<entry>
<changenumber>77091</changenumber>
<msg>Change slave restriction to use variables
</msg>
<changeUser>rsqu</changeUser>
<changeTime>Wed Dec 03 17:12:52 GMT 2014</changeTime>
</entry>
<entry>
<changenumber>77083</changenumber>
<msg>U_MA_TLS-219 : Add ability to customize upstream builds and numbers
U_MA_TLS-223 : Fix problem with columns
</msg>
<changeUser>mjou</changeUser>
<changeTime>Wed Dec 03 17:02:01 GMT 2014</changeTime>
</entry>
<entry>
<changenumber>76886</changenumber>
<msg>Change slave restrictions to use variables
Tested on the SDMOS CI stream
</msg>
<changeUser>rsqu</changeUser>
<changeTime>Wed Dec 03 11:42:26 GMT 2014</changeTime>
</entry>
<entry>
<changenumber>76572</changenumber>
<msg>U_MA_TLS-222 : Add auto detection of P4 credential from server
</msg>
<changeUser>mjou</changeUser>
<changeTime>Tue Dec 02 11:15:55 GMT 2014</changeTime>
</entry>
etc.
i can very easily get the above info via:
p4 = new ClientHelper(credential, listener, client);
for(int i=0; i<changes.size(); i++){
Changelist cl=p4.getChange(changes.get(i));
changesFull.add(cl);
}
where changes are the normal list of changenumbers.
When the REST calls or GUI now request the info, the plugin should just read the full change info from the XML file, and not retrieve them every time.
This is causing me a severe pain since my P4 server is in another country and i use the REST calls extensively.
|
