[JIRA] [core] (JENKINS-10944) MatrixProject can run on a heavyweight executor, leading to deadlocks

[jgl...@cloudbees.com (JIRA)]

Jesse Glick commented on JENKINS-10944 MatrixProject can run on a heavyweight executor, leading to deadlocks The reproduction case for JENKINS-24519 does not involve quieting down, it involves a slave being temporarily offline. But you may be right that the faulty code path and thus fix is the same: do not proceed to p.enter(this) when p.task instanceof FlyweightTask. I am not sure what should be done instead: from the callers of makeBuildable it seems that merely returning without doing anything is not correct either, that we would need to actually revert to the waiting state. Will have to examine this a bit more closely, starting by reproducing at least one of the failure modes in a test. it makes sense to not schedule Flyweight tasks while quieting down if they're not NonBlockingTask, however it makes no sense for them to be treated like normal ("heavyweight") tasks afterwards Agreed on both points.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.