|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
src/com/trilead/ssh2/Connection.java
src/com/trilead/ssh2/KnownHosts.java
src/com/trilead/ssh2/RandomFactory.java
http://jenkins-ci.org/commit/trilead-ssh2/961adfb2762d84e952c3b49126adaa5fa2c4933e
Log:
JENKINS-20108
Prefer SHA1PRNG, which avoids VM-wide global lock on Unix.
Another way to fix this is to avoid repeated calls to "rnd.nextInt()" in
TransportConnection.sendMessage() and instead get all the padding in one call.
That would require another byte array as there's no SecureRandom.nextBytes(byte[],int,int),
but that'd be a monitor cost in the face of VM-wide lock across all the SecureRandom instances.
The amount of padding is fairly small, so yet another way to fix this is to buffer random bytes
by hitting SecureRandom in a bigger block (thus infrequentl) and save the rest at Connection.