[JIRA] [cygpath] (JENKINS-20364) Failed to locate cygwin installation

[neeme.pr...@eesti.ee (JIRA)]

Neeme Praks commented on JENKINS-20364 Failed to locate cygwin installation I'm also having this problem (at least from the description, it looks similar). I tracked it down to difference between 32bit JVM vs 64bit JVM. The plugin was consistently failing with 32bit JVM (Java 7) and it works with 64bit JVM. My environment: 64-bit Windows 7 (6.1.7601 Service Pack 1 Build 7601) 64-bit JVM: java version "1.7.0_40" Java(TM) SE Runtime Environment (build 1.7.0_40-b43) Java HotSpot(TM) 64-Bit Server VM (build 24.0-b56, mixed mode) 32-bit JVM: java version "1.7.0_40" Java(TM) SE Runtime Environment (build 1.7.0_40-b43) Java HotSpot(TM) Client VM (build 24.0-b56, mixed mode, sharing) If I open registry editor, then I can see that "HKEY_LOCAL_MACHINE\SOFTWARE\Cygwin\setup" key exists. Other options that cygpath plugin tried to locate do not exist. All options: HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygwin\setup HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygnus Solutions\Cygwin\mounts v2\/ HKEY_LOCAL_MACHINE\SOFTWARE\Cygwin\setup HKEY_LOCAL_MACHINE\SOFTWARE\Cygnus Solutions\Cygwin\mounts v2\/ (so, the third should succeed) The problem is the "access" flag that is passed to "RegOpenKeyEx" API call: it has the value for READ_ONLY (0x20019) but should also contain either 0x0100 (KEY_WOW64_64KEY) or 0x0200 (KEY_WOW64_32KEY), depending on the running JVM (either 32bits or 64bits). The relevant part in RegistryKey class: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/util/jna/RegistryKey.java#L217 Useful reading: http://windowsitpro.com/systems-management/whats-wow6432node-under-hkeylocalmachinesoftware-registry-subkey http://msdn.microsoft.com/en-us/library/windows/desktop/aa384129(v=vs.85).aspx Also, I'm not sure the change made in JENKINS-7303 actually fixes anything (did someone test this?). The "Wow6432Node" subkey seems to be implementation detail of Windows registry and the application code should not care about it. Instead, it should use the relevant access bit (as described above). Also, my tests have shown that with current code, 64bit JVM running on 64bit Windows can access "HKEY..WARE\Cygwin\setup". The problem is with 32bit JVM running on 64bit Windows: it looks up "HKEY..WARE\Cygwin\setup" but Windows translates that into "HKEY..WARE\Wow6432Node\Cygwin\setup" (which is missing). And, when it tries to access "HKEY..WARE\Wow6432Node\Cygwin\setup", Windows probably translates that into "HKEY..WARE\Wow6432Node\Wow6432Node\Cygwin\setup" which is also missing. So 32bit JVM running on 64bit Windows has no access to "HKEY..WARE\Cygwin\setup" unless it specifies the special KEY_WOW64_64KEY flag. I'm not sure if the other scenario of 64bit JVM running on 64bit Windows trying to look up "HKEY..WARE\Wow6432Node\Cygwin\setup" works or KEY_WOW64_32KEY flag should be used instead (covering the case when "HKEY..WARE\Cygwin\setup" is missing but "HKEY..WARE\Wow6432Node\Cygwin\setup" exists). Should probably test that.

This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.