Daniel Beck commented on New Feature JENKINS-23333

Looks great!

labels assigned to jobs are not normalized by Jenkins: if the user enters “jdk7&&master” in one job and “master&&jdk7” in another one, they will be seen as two different labels. The plugin follows this behavior, and puts these jobs in two distinct categories

Makes sense. Jenkins doesn't consider them equal either despite Label implementing Comparable.

the new page lists all jobs that reference the specific label, regardless of the meaning of the full label. So “windows&&!msbuild” jobs will be shown on the page for label “msbuild”. As a user I think it makes sense functionally, and the reason why a job is shown on the page is clearly stated (“Job(s) configured with <label_something>”)

Makes sense. Since it groups by label, it's clear that labels may be inverted (only those "NOT something"), or even useless (label||!label and similar, less obvious rules).

while I was testing that I noticed that it’s possible to assign labels to a node starting with !. This leads to unexpected behavior. Not sure if it’s worth reporting it (maybe it’s already reported?)

Not sure what you mean. If the node is called 'foo' and you specify '!foo' as label, it'll run on any other node (!windows could be a shortcut for e.g. osx||linux||solaris in a particular setup). If OTOH the node is called '!foo' because the naming conventions don't take label expressions into account (didn't check whether that's possible though), reporting that would be useful. Seems related to similar reports of brokenness related to labels.

for the display of each group of jobs I used the standard projects’ list view

Personally I find these list view lists very noisy and would prefer a minimal view similar to what is shown on the label index page for exact matches, but I recognize that's subjective and your use case may even require it to look like that.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to