Jesse Glick commented on Bug JENKINS-20663

passed in the value of System.getProperty("file.encoding")

I.e., Charset.defaultCharset().

I am not convinced this prior behavior was actually correct, though there is no clear answer. Cp437 is apparently the traditional encoding for ZIP files. JAR files specify UTF-8 unless told otherwise, which is what the current code uses. The file encoding that the Jenkins master happens to use may or may not match the file encoding used by the slave that ran the build producing the artifact, or the computer which has downloaded the artifact ZIP and wishes to extract it. Possibly the encoding should be taken from the Accept-Charset header in the request, if any.

Really the only safe policy is to use UTF-8 on all computers you touch; this is the default file encoding on all modern Linux distributions that I know of, but other OSs use different defaults.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to