[JIRA] [git] (JENKINS-22342) Gitweb URL can be mangled (if it doesn't contain a path?)

Thu, 10 Apr 2014 05:01:14 -0700

Mark Waite commented on Bug JENKINS-22342

It appears this change breaks the previously working githubweb links until the next time the job is saved. We can't release the plugin with that behavior because we can't force our users to save the job definition in order to restore something that was working previously.

The steps I took to show the problem were:

  1. Define a job using GitHub URL https://github.com/jenkinsci/git-plugin and GitHub repository browser URL https://github.com/jenkinsci/git-plugin
  2. Save that job
  3. Let the job run when changes arrive on that GitHub project
  4. Upgrade the git plugin to the latest unreleased version
  5. Open the job and click one of the recent changes links to githubweb. A slash will be missing from the githubweb URL. Instead of fb12fed it will be https://github.com/jenkinsci/git-plugincommit/fb12fed4c1c8af11db68ec236961401d3d11eb7b
  6. Configure the job
  7. Save that configuration without making any changes
  8. Click one of the recent change links to githubweb. A slash will be inserted correctly into the githubweb URL. The link fb12fed works

We can't release a version of the plugin which requires every job to be visited. Some Jenkins servers have hundreds of jobs configured. Can you propose a change which will fix that case? If you don't have time for that, I'll reopen the bug and revert this change so that plugin releases of other fixes and improvements are not blocked.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to