|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
I can confirm that the Takayuki Hirota pull request breaks the git client on windows. The back slashes are required otherwise the config file ends up with the wrong path to the credentials file.
However both Configure and Git Polling are still broken (both with status code 255) on Windows. I think this is because there is no git checkout directory with which to run the git config --local command. Normally a ls-remote shouldn't require one, but we are trying to store the credentials in the 'local' file, which stores the configuration in the repository specific configuration file (see config documentation).
One alternative would be to store the credentials in the global configuration instead, but that would seem to break the point of the JENKINS-20318 development in that multiple executors couldn't the connect to the same repository using different credentials.
The other approach would be to ensure that we always run a command within a initialised repository directory (i.e. git init has been run first). I've tried changing the getHeadRev within CliGitAPIImpl.java to pass in the current workspace, but that didn't work as the workspace was set to null during the Git Polling. I'm not sure at what stage the Jenkins workspace is created. For Configure to work, when the user selects Git as the SCM and chooses the credentials we will then need to do a git init before running the first git config command.
For now, I've hacked my local copy of the plugin to run in global mode, which works for me as I don't need to access a repository with different credentials under different circumstances. See https://github.com/pphillips-techphob/git-client-plugin for that version instead.