Martin Schröder edited a comment on Bug JENKINS-13666

Hello Sogabe.

I admit, that I have no insight into the actual behaviour of the build-timeout plug-in, so I can't say whether or not it is to blame for this issue.

But if I look at the source-code of the plug-in [1], I see that the line that causes the failure is this:

-----------------------
public EnvironmentImpl() { long timeout; [... assigning value to'timeout' ...] this.effectiveTimeout = timeout; task = new TimeoutTimerTask(build, listener); Trigger.timer.schedule(task, timeout); }
------------------------

[1] - https://github.com/jenkinsci/build-timeout-plugin/blob/master/src/main/java/hudson/plugins/build_timeout/BuildTimeoutWrapper.java

The plug-in fails at that last line. The interesting thing is just that it DOES NOT complain about the task being invalid. Instead, it complains about "Trigger.timer" having been already cancelled.

So the root question is, what cancels this field 'timer' in "hudson.triggers.Trigger"? I can't see anything in the plug-in's code that would do that. The only cancel() it calls is on the task itself – but that should as far as I know not cancel the Trigger.timer field it is contained in.

Additionally, even if the plug-in checks this field for if it has been cancelled or not, all that would do is to move the failure from the Build-Timeout-plugin to the next plug-in that makes use of this field from the Trigger class. As far as I know, many plug-ins directly or indirectly use this field via the many "<something>PeriodicWork" classes of Jenkins.

Best regards,
Martin Schröder.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to