|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
To generally reduce the likelihood of dead locks like this, we should prefer lock-less code wherever possible. I'm changing Project.getPublishersList() to not to require a locking by using a volatile field.
I experimented a little with using AtomicReference, which looks cleaner, but making this work transparently with XStream turns out to be very difficult, especially when the element in XML may not be present.
The other obvious approach is to the instantiation code in onLoad, but this method is getting complex enough that we need to worry about fixing up fields in the correct order, and IIRC the reason we moved the initializer into the getter method in the first place was because we had such an ordering issue.