[JIRA] (JENKINS-59193) Session-ID missing alongside CSRF tokens

[m...@basilcrow.com (JIRA)]

Title: Message Title

Basil Crow commented on JENKINS-59193   Re: Session-ID missing alongside CSRF tokens Daniel Katz Hiroki OHZAKI Can you provide me with a list of steps to reproduce the issue? Bonus points if you can submit a PR with a failing unit test. I tried updated the unit tests to use Jenkins 2.176.3 and DefaultCrumbIssuer, but the tests still passed: diff --git a/plugin/src/test/java/hudson/plugins/swarm/SwarmClientIntegrationTest.java b/plugin/src/test/java/hudson/plugins/swarm/SwarmClientIntegrationTest.java index b4d1f12..426e01c 100644 --- a/plugin/src/test/java/hudson/plugins/swarm/SwarmClientIntegrationTest.java +++ b/plugin/src/test/java/hudson/plugins/swarm/SwarmClientIntegrationTest.java @@ -12,6 +12,7 @@ import hudson.model.FreeStyleProject; import hudson.model.Node; import hudson.plugins.swarm.test.ProcessDestroyer; import hudson.plugins.swarm.test.TestUtils; +import hudson.security.csrf.DefaultCrumbIssuer; import hudson.tasks.BatchFile; import hudson.tasks.CommandInterpreter; import hudson.tasks.Shell; @@ -28,6 +29,7 @@ import org.apache.commons.lang.RandomStringUtils; import org.apache.commons.lang.math.NumberUtils; import org.junit.After; import org.junit.Assume; +import org.junit.Before; import org.junit.ClassRule; import org.junit.Rule; import org.junit.Test; @@ -51,6 +53,11 @@ public class SwarmClientIntegrationTest { private final ProcessDestroyer processDestroyer = new ProcessDestroyer(); + @Before + public void setIssuer() { + j.jenkins.setCrumbIssuer(new DefaultCrumbIssuer(false)); + } + /** Executes a shell script build on a Swarm Client agent. */ @Test public void buildShellScript() throws Exception { diff --git a/pom.xml b/pom.xml index cdaf0ed..3c7d7c2 100644 --- a/pom.xml +++ b/pom.xml @@ -24,7 +24,7 @@ <version>3.18-SNAPSHOT</version> <properties> - <jenkins.version>2.60.3</jenkins.version> + <jenkins.version>2.176.3</jenkins.version> <java.level>8</java.level> </properties> Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201634.1567450478000.4969.1572387480490%40Atlassian.JIRA.