[JIRA] (JENKINS-59303) Jenkins plugin restart option shouldn't restart if there are no plugins to install

[jsoref+jenk...@gmail.com (JIRA)]

Title: Message Title

Josh Soref created an issue   Jenkins / JENKINS-59303 Jenkins plugin restart option shouldn't restart if there are no plugins to install Issue Type: Improvement Assignee: Unassigned Components: core Created: 2019-09-10 21:55 Priority: Minor Reporter: Josh Soref Steps: Visit http://jenkins/pluginManager/ See an update notice for a plugin (GitHub Branch Source) Select it Click Download now and install after restart Click the Restart Jenkins when installation is complete and no jobs are running box Get an error that the plugin can't be updated Jenkins still insists on restarting Expected results: Restart should only be performed if there are actually plugins that were successfully downloaded and require a restart to install, otherwise the restart task should be canceled. Jenkins is going to shut down Installing Plugins/Upgrades Preparation Checking internet connectivity Checking update center connectivity Success GitHub Branch Source  Failure -java.io.FileNotFoundException: http://archives.jenkins-ci.org/plugins/github-branch-source/2.5.7/github-branch-source.hpi at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1896) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498) at sun.net.www.protocol.http.HttpURLConnection.getHeaderField(HttpURLConnection.java:3057) at java.net.URLConnection.getHeaderFieldLong(URLConnection.java:629) at java.net.URLConnection.getContentLengthLong(URLConnection.java:501) at java.net.URLConnection.getContentLength(URLConnection.java:485) at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:1161) Caused: java.io.FileNotFoundException: http://archives.jenkins-ci.org/plugins/github-branch-source/2.5.7/github-branch-source.hpi at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1950) at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1945) at java.security.AccessController.doPrivileged(Native Method) at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1944) at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1514) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498) at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:1177) Caused: java.io.IOException: Failed to load http://updates.jenkins-ci.org/download/plugins/github-branch-source/2.5.7/github-branch-source.hpi to /var/lib/jenkins/.jenkins/plugins/github-branch-source.jpi.tmp at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:1184) Caused: java.io.IOException: Failed to download from http://updates.jenkins-ci.org/download/plugins/github-branch-source/2.5.7/github-branch-source.hpi (redirected to: http://archives.jenkins-ci.org/plugins/github-branch-source/2.5.7/github-branch-source.hpi) at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:1218) at hudson.model.UpdateCenter$DownloadJob._run(UpdateCenter.java:1766) at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:2037) at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1740) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:111) at java.lang.Thread.run(Thread.java:748) Restarting Jenkins  Running Go back to the top page (you can start using the installed plugins right away) Restart Jenkins when installation is complete and no jobs are running Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201851.1568152548000.1031.1568152560324%40Atlassian.JIRA.