[JIRA] (JENKINS-55420) local variables in shared-library global vars being treated globally

[brian.murr...@intel.com (JIRA)]

Title: Message Title

Brian J Murrell created an issue   Jenkins / JENKINS-55420 local variables in shared-library global vars being treated globally Issue Type: Bug Assignee: Unassigned Components: pipeline Created: 2019-01-07 06:08 Environment: Jenkins ver. 2.121.2 Priority: Critical Reporter: Brian J Murrell I have a shared library that defines a global variable provisionNodes. Inside that global variable a local variable is defined to hold the value of a passed in parameter: nodeString = config['NODELIST'] The following code then optionally reassigns the variable if a subset of nodes is wanted (the logic of below is not really important): if (config['node_count']) { node_list = config['NODELIST'].split(',') node_cnt = node_list.size() if (config['node_count'] < node_cnt) { // take is blacklisted by Jenkins. //new_list = node_list.take(config['clients']) new_list = [] for (ii = 0; ii < config['node_count']; ii++) { new_list.add(node_list[ii]) } nodeString = new_list.join(',') } else if (config['node_count'] > node_cnt) { echo "${config['node_count']} clients requested." error "Only ${node_cnt} clients available!" } } ... And then a bit later that variable is used in a shell command: rc = sh script: """./jenkins/test_manager/wait_for_node_ready.py \ --nodes=${nodeString} ${woptions}""", If the global variable provisionNodes is run a number of times in parallel from a parallel block in a Jenkinsfile, the nodeString variable is being shared across all running instances in the parallel block such that the last instance to assign nodeString before they all get to the above code block, is setting the value for all instances and they all end up with same argument of nodes to the above shell call. Is this expected?  It's not at all embracing the principle of least surprise if it is. and if it is, how do I get nodesString (and every other variables) local scope back as I would expect it? Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.