lukas rytz commented on Improvement JENKINS-10502

Changing the behavior for people that are currently using the system property is not an option, IMO.

I think the logic should be something like

if (archives-non-existent) {
  if (job.onlyWarnOnEmptyArtifacts.isDefined && job.onlyWarnOnEmptyArtifacts.isSet) {
    newWarning();  // or whatever needs to be done
  } else if (systemProperty(warnOnEmpty).isDefined) {
    oldWarning();  // don't change behavior of existing installation.
                   // the system property is still considered even if the new setting exists (and is not enabled) in the job config
                   // (add that to the documentation). the reason: just saving the job config might add the setting to the config,
                   // without the user noticing.
  } else {
    fail();        // default behavior, don't change
  }
}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to