[JIRA] (JENKINS-54186) No @DataBoundConstructor on any constructor of class jenkins.plugins.git.GitSCMSourceDefaults

[jgl...@cloudbees.com (JIRA)]

Title: Message Title

Jesse Glick commented on JENKINS-54186   Re: No @DataBoundConstructor on any constructor of class jenkins.plugins.git.GitSCMSourceDefaults MergeWithGitSCMExtension and GitSCMSourceDefaults deliberately lack descriptors and are not intended to be databound. This is a bug in ArgumentsActionImpl resulting from the fix of JENKINS-54032. I suspect something like diff --git a/src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java b/src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java index dd292481..0bacdc36 100644 --- a/src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java +++ b/src/main/java/org/jenkinsci/plugins/workflow/cps/actions/ArgumentsActionImpl.java @@ -291,6 +291,9 @@ public class ArgumentsActionImpl extends ArgumentsAction { } else if (tempVal instanceof UninstantiatedDescribable) { tempVal = ((UninstantiatedDescribable)tempVal).toMap(); } else if (tempVal instanceof Describable) { // Raw Describables may not be safe to store, so we should explode it + if (Jenkins.get().getDescriptor(tempVal.getClass().asSubclass(Describable.class)) == null) { + return NotStoredReason.UNSERIALIZABLE; + } m = DescribableModel.of(tempVal.getClass()); tempVal = m.uninstantiate2(o).toMap(); } would fix it, but the issue needs to be reproduced in a functional test first. Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.