[JIRA] (JENKINS-53750) Shell scripts keep the working directory locked on Windows

[roman.donche...@intel.com (JIRA)]

Title: Message Title

Roman Donchenko created an issue   Jenkins / JENKINS-53750 Shell scripts keep the working directory locked on Windows Issue Type: Bug Assignee: Unassigned Components: durable-task-plugin Created: 2018-09-24 16:58 Environment: Jenkins 2.138.1 Durable Task plugin 1.22 Labels: windows sh Priority: Major Reporter: Roman Donchenko Try to run the following pipeline on a Windows node (you'll need a Unix shell port; I am using bash from Git for Windows): node('mynode') { stage('Test') { dir('foo/bar') { sh 'sleep 1' } bat 'rename foo baz' } } The bat step will fail with an "Access is denied" message. It seems that the reason for this is that when the Durable Task plugin runs its wrapper script (in BourneShellScript.launchWithCookie), it doesn't wait for the wrapper process to finish before it allows pipeline execution to proceed to the next step. It only waits until the result file gets created. This means that for a fraction of time, the bat step will be running concurrently with these three processes created for the sh step: The wrapper script. The nohup process that is its parent. The background job that the wrapper script creates to periodically touch the log file. And that fraction can be significant, because the background job sleeps in intervals of three seconds. Now, those processes have as their working directory the directory of the sh step, which on Windows means that that directory is locked - it cannot be deleted, and its parent cannot be moved. And since the bat step starts executing before those processes terminate, it cannot rename the foo directory, even though it really should be able to. To solve this, ideally, the Durable Task plugin should wait for the nohup process to terminate before proceeding with the next step. Failing that, it should at least make sure that the working directories of the auxiliary processes it spawns aren't within the workspace. (I'm unable to easily test this using the most recent version of the plugin, but I reviewed the changes made since 1.22 and I'm fairly confident that the latest version still exhibits this issue.) Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.