[JIRA] (JENKINS-53709) Parallel blocks in node blocks cause executors to be persisted outside of the node block

[dnusb...@cloudbees.com (JIRA)]

Title: Message Title

Devin Nusbaum updated an issue   Jenkins / JENKINS-53709 Parallel blocks in node blocks cause executors to be persisted outside of the node block Change By: Devin Nusbaum When a {{parallel}} step is nested in a {{node}} step, the executor associated with the node appears to outlive both the {{parallel}} and {{node}} steps. This leads to the executor being rehydrated when a pipeline is restarted, even if the pipeline is outside of the node block. Reproduction test case: {code}     @Test public void shouldNotLeakExecutorsViaContextVars() {         story.then(r -> {             DumbSlave s = r.createOnlineSlave();             WorkflowJob p = r.jenkins.createProject(WorkflowJob.class, "demo");             p.setDefinition(new CpsFlowDefinition("node('" + s.getNodeName() + "') {\n" +                     "  parallel one: {\n" +                     "    echo '" + s.getNodeName() + "'\n" +                     "  }\n" +                     "}\n" +                     "semaphore 'wait'\n", false));             WorkflowRun b = p.scheduleBuild2(0).waitForStart();             SemaphoreStep.waitForStart("wait/1", b);             r. disconnectSlave jenkins.removeNode (s);         });         story.then(r -> {             WorkflowRun b = r.jenkins.getItemByFullName("demo", WorkflowJob.class).getBuildByNumber(1);             SemaphoreStep.waitForStart("wait/1", b);             SemaphoreStep.success("wait/1", null);             while (b.isBuilding()) {                 r.assertLogNotContains(" is offline Jenkins doesn’t have label ", b);                 Thread.sleep(100);             }             r.assertBuildStatusSuccess(b);         });     } {code} This test currently fails because the pipeline waits for the 'Test' agent to become available after restarting even though we are not in a node block. From a quick investigation, I think this may have been introduced by JENKINS-26034 ([commit|https://github.com/jenkinsci/workflow-cps-plugin/commit/c8c668f2b60a19c33add92e2b14345f23f58aabc]), because if I remove [ResultHandler.stepExecution|https://github.com/jenkinsci/workflow-cps-plugin/blob/54d2f4fe8069fde53789bfe21229ce8e545300bb/src/main/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStep.java#L70], the test case passes successfully. I'm not sure if we shouldn't be persisting the execution there, or if we need to clear it out after the step completes, or if the persistence is fine and the root problem is somewhere else. Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.