[JIRA] (JENKINS-53485) File Leak in libraryResource pipeline step

[tschai...@gmail.com (JIRA)]

Title: Message Title

Tom Schaible created an issue   Jenkins / JENKINS-53485 File Leak in libraryResource pipeline step Issue Type: Bug Assignee: Unassigned Attachments: image-2018-09-07-20-54-12-144.png Components: workflow-cps-global-lib-plugin Created: 2018-09-08 00:57 Environment: Any Jenkins server using v2.10 of the workflow-cps-global-lib plugin Priority: Major Reporter: Tom Schaible Recently, we have been seeing our Jenkins instance regularly consume a ton of file descriptors, to the point of maxing out the users limit. This growth is quite visible when using the monitoring plugin attached at the bottom. We had fairly stable performance up until this point. In investigating, the files that were open in large frequencies were almost always files that had been loaded with the libraryResource pipeline step. Upon further investigation, I found this recent change. Previously, the implementation used FilePath.readToString() in order to read the file.  This method uses a try-with-resources to read the InputStream, ensuring the input is closed prior to the method exiting. The newer implementation has lost this safety, causing a file leak anytime a file is ready with libraryResource.   We had fairly  Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.