[JIRA] (JENKINS-52983) Missing root URL in the generated link to build while using groovy-html.template

[gregory.f...@virgingalactic.com (JIRA)]

Title: Message Title

Gregory Fong commented on JENKINS-52983   Re: Missing root URL in the generated link to build while using groovy-html.template I am hitting this issue with the Stash Pullrequest Builder plugin after we upgraded to 2.140, and we do have a jenkins.model.JenkinsLocationConfiguration.xml file. Exploring a bit, this plugin uses this code in order to get the URL (see https://github.com/nemccarthy/stash-pullrequest-builder-plugin/blob/master/src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuilds.java#L52): JenkinsLocationConfiguration globalConfig = new JenkinsLocationConfiguration(); String rootUrl = globalConfig.getUrl(); However, I confirmed using script console that this returns null in 2.140: JenkinsLocationConfiguration globalConfig = new JenkinsLocationConfiguration(); println(globalConfig.getUrl()); On the other hand, running the following on script console returns the configured URL as expected: config = JenkinsLocationConfiguration.get(); println(config.getUrl()) It looks like the commit that caused this difference in behavior is: https://github.com/jenkinsci/jenkins/commit/c3988aae8ad66fde529830e799fe3d49cd241ebb#diff-1439884ddd002c6ca6463d9657412b15 .  It seems like constructing a new JenkinsLocationConfiguration no longer invokes the load() method automatically, and I confirmed that calling it manually does result in the configured URL being returned as expected: JenkinsLocationConfiguration globalConfig = new JenkinsLocationConfiguration(); globalConfig.load() println(globalConfig.getUrl()); I can't say that what plugins are doing is right or wrong, but the new behavior does break some plugins.  If this is a policy change for plugins, then I can open a bug ticket or submit a pull request for this particular plugin.  But it'd be good to get some feedback from someone who understands the problem better to answer this question: Is this an problem with the plugin's expectations, or is this a Jenkins regression? Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.