[JIRA] (JENKINS-50480) UnsupportedOperationException: Refusing to marshal com.github.dockerjava.api.*

[jgl...@cloudbees.com (JIRA)]

Title: Message Title

Jesse Glick commented on JENKINS-50480   Re: UnsupportedOperationException: Refusing to marshal com.github.dockerjava.api.* Going by diff --git a/src/main/java/io/jenkins/docker/DockerTransientNode.java b/src/main/java/io/jenkins/docker/DockerTransientNode.java index eb3cf8c..3ee4916 100644 --- a/src/main/java/io/jenkins/docker/DockerTransientNode.java +++ b/src/main/java/io/jenkins/docker/DockerTransientNode.java @@ -84,6 +84,10 @@ public class DockerTransientNode extends Slave { } public void terminate(TaskListener listener) { + if (this != null) { + System.err.println("===> would terminate now"); + return; + } try { toComputer().disconnect(new DockerOfflineCause()); listener.getLogger().println("Disconnected computer"); diff --git a/src/test/java/io/jenkins/docker/connector/DockerComputerJNLPConnectorTest.java b/src/test/java/io/jenkins/docker/connector/DockerComputerJNLPConnectorTest.java index 7c3bda3..0e7633f 100644 --- a/src/test/java/io/jenkins/docker/connector/DockerComputerJNLPConnectorTest.java +++ b/src/test/java/io/jenkins/docker/connector/DockerComputerJNLPConnectorTest.java @@ -41,6 +41,7 @@ public class DockerComputerJNLPConnectorTest extends DockerComputerConnectorTest } should_connect_agent(template); + Thread.sleep(Long.MAX_VALUE); } it seems that the agent is in fact launched, and the build succeeds, despite the fact that the agent configuration is not stored on disk. If true, the problem could perhaps be reproduced using RestartableJenkinsRule with a WorkflowJob; it seems that there is no Pipeline test of DockerCloud at all (only DockerNodeStepTest, unrelated). This could arguably be considered a bug in Jenkins core: Nodes.addNode throws up any exception from persistNode, but then neglects to remove the faulty node from its list, whereas you would expect Jenkins.addNode to succeed or fail atomically. Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.