Issue Type: Bug Bug
Affects Versions: current
Assignee: Nicolas De Loof
Components: git
Created: 12/Nov/12 11:51 AM
Description:

We have a problem on the ASF git integration that causes change detection logic to always trigger changes, subsequently running the builds non-stop.

I am quiet sure I have tracked this and will explain it here:

jenkins-core:

https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/AbstractProject.java#L1404

Look at the catch-block surrounding the call to "poll".

https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitSCM.java#L678
https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitSCM.java#L741

Both of these method calls can produce a "GitException" which is of type RunTimeException. When they hit the "catch" in AbstractProject#poll, they will enter the RuntimeException block.

The root cause seems to be that GitAPI status code detection (GitAPI java line 824) does not distinguish between "IOException" and other kinds of exception. Given that we are unable to distinguish, it probably makes more sense to make the "poll" method wrap any git exception in an IOException, but the optimal would be to determine what status codes git uses for network related failures and throw ioexceptions in those cases.

Project: Jenkins
Priority: Major Major
Reporter: Kristia Rosenvold
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to