[JIRA] (JENKINS-38058) Properly pass context in folder's page objects

[mfra...@cloudbees.com (JIRA)]

Title: Message Title

Manuel Franco updated an issue   Jenkins / JENKINS-38058 Properly pass context in folder's page objects Change By: Manuel Franco Let's describe the issue with a test. Assumming we already have an injector and a JenkinsController, the following test will fail: {code:java} Jenkins j1 = new Jenkins(injector, jenkinsController); Assert.assertSame(j1, j1.jobs.getJenkins()); Jenkins j1 = new Jenkins(injector, jc);         Assert.assertSame(j1, j1.jobs.getJenkins());                  FolderItem f = j1.jobs.create(FolderItem.class);         Assert.assertSame(j1, f.jobs.getJenkins()); {code} The problem is that the jenkins instance returned by the {{getJenkins()}} method in the {{JobsMixIn}} object (actually inherited from {{PageObject}}) is not the instance that was passed as a context in the construction of this last one, but an instance that is looked up (and built if needed) using guice. This leads to potential inconsistencies for some operations (e.g. {{jobs.create}}) that rely on querying its jenkins instance, for example for the version number. Sometimes as an [external user|https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/EXTERNAL.md] of the ATH I may need to create several instances with different versions, and want each jobs mixin to know exactly to which jenkins they belong to and behave consistently. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.