[JIRA] [gerrit-trigger-plugin] (JENKINS-32898) Disable Strict Forbidden File Verification option always causes trigger

[joseph.a...@greenwayhealth.com (JIRA)]

Title: Message Title

Joseph Ajax created an issue   Jenkins / JENKINS-32898 Disable Strict Forbidden File Verification option always causes trigger Issue Type: Bug Assignee: rsandell Components: gerrit-trigger-plugin Created: 11/Feb/16 4:01 PM Environment: Jenkins 1.642.1, gerrit-trigger-plugin 2.18.3 Priority: Minor Reporter: Joseph Ajax The Disable Strict Forbidden File Verification option appears to break all file/Topic level triggering. According to the in job config help regarding this option: Enabling this option will allow an event to trigger a build if the event contains BOTH one or more wanted file paths AND one or more forbidden file paths. In other words, with this option, the build will not get triggered if the change contains only forbidden files, otherwise it will get triggered. I noticed when I had 2 files set as forbidden files and none in the add file path, if I checked in a change with just those 2 files it would still trigger the job. Looking at the definition of the GerritProject.isInteresting(...) method (GerritProject.java line 215), if disableStrictForbiddenFileVerification is true, a trigger will occur regardless of matches for topics, files or forbidden files. The code appears to be at odds with the expected documented behavior. As it currently stands, if a specified branch matches and the Disable Strict Forbidden File Verification option is selected. It does not matter what is in the topics, files or forbidden files fields: the job will be always be triggered. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.