[JIRA] [git-plugin] (JENKINS-30475) bad design for Polling vs Checkout algorithms

[gentoo.inte...@gmail.com (JIRA)]

Title: Message Title

Kanstantsin Shautsou updated an issue   Jenkins / JENKINS-30475 bad design for Polling vs Checkout algorithms Change By: Kanstantsin Shautsou After long time of debugging i found that current polling algorithm works in the next way: # Get from remote repo branchnames + sha1 # compare with existed BuilData  in  from  latest build (ONE logic) # If sha1/branch not found -> trigger build (NO RPA attached) # Build is running and it calls checkout() step in GITScm # checkout() calls getBuildRevision that calls DefaultBuildChooser that calls getAdvancedCandidateRevisions() that calls revs = GitUtils.filterTipBranches(revs); (SECOND logic) # filter tips removes all intermediate branches and they never appears in BuildData That ends in situations that Polling needs branches, but checkout didn't build them. I fixed this issue by commenting tips filtering https://github.com/KostyaSha/git-plugin/commit/8336202ee5ec8d5a12caa875aeba27b89ac3af58 this allowed build all branches and Polling now satisfied. Suggestion: # Put RPA as polling result for triggered build -> allows ensure that BuildData will get what polling wants # Use the same logic for checkout and polling -> more or less allows hope that checkout will pick what polling mean Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.