[
https://issues.jenkins-ci.org/browse/JENKINS-13324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161703#comment-161703
]
SCM/JIRA link daemon commented on JENKINS-13324:
------------------------------------------------
Code changed in jenkins
User: Rob Petti
Path:
src/main/java/hudson/plugins/perforce/PerforceMailResolver.java
http://jenkins-ci.org/commit/perforce-plugin/1986bb15c18ccbae3f5c2e597db1a549691f4504
Log:
[FIXED JENKINS-13324] don't return invalid email addresses in mailresolver
it will now check that the email address matches '.+@.+' before returning it to
jenkins
> Perforce mail address resolver should fall back to other resolvers if mail
> address is invalid
> ---------------------------------------------------------------------------------------------
>
> Key: JENKINS-13324
> URL: https://issues.jenkins-ci.org/browse/JENKINS-13324
> Project: Jenkins
> Issue Type: Bug
> Components: perforce
> Environment: Perforce 2011.1
> perforce-plugin 1.3.12
> Reporter: Mikko Tapaninen
>
> Perforce mail address resolver is always returning a string, no matter what
> the actual email address is. I don't know what is the order how Jenkins loops
> through the various MailAddressResolver instances but if some instance
> returns an actual string (i.e. non-null), it will stick with that. I don't
> think it's feasible to really check whether the email address provided by
> Perforce is valid, but PerforceMailResolver could check for some value (e.g.
> "n/a") and return null if it matches. At least with Perforce 2011.1 you can't
> have an empty value for an email address.
> There could be an UI element for configuring which email address would be
> thought as invalid, but I'm fine with hardcoding "n/a" there and documenting
> it somewhere. Would this be ok?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
