[
https://issues.jenkins-ci.org/browse/JENKINS-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159892#comment-159892
]
SCM/JIRA link daemon commented on JENKINS-12881:
------------------------------------------------
Code changed in jenkins
User: Joe Hansche
Path:
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java
http://jenkins-ci.org/commit/gerrit-trigger-plugin/f79e10be25028ad69a433a82b061ebc1bd6371d2
Log:
JENKINS-12881: Obtain failure message at completed-time.
Resolves a potential race condition when a single job
may be executing multiple times before the change "batch"
status is ready to be reported back to Gerrit.
The test setup is:
* Job-A
- Shell: echo "Starting ${BUILD_TAG}" > error-message.txt
sleep 5
- Shell: echo "Always fails ${BUILD_TAG}" > error-message.txt
sleep 5
exit 1
* Job-B
- Shell: echo "Starting ${BUILD_TAG}" > error-message.txt
sleep 15
- Shell: echo "Never fails ${BUILD_TAG}" > error-message.txt
sleep 15
Job-B will always be the long-pole (30 sec). Job-A will always fail,
hopefully with "Always fails ______" as the error-message.
Create 2 commits for review, and push both commits to Gerrit. Both
Job-A builds will run and fail within 20 seconds, before the first
Job-B build is even finished executing.
The test is successful if both review commits contain the correct
"Always fails {TAG}" messages, corresponding to the correct URL.
The test fails if any other string exists in the failure message.
> Allow reading custom build message from a workspace file, in case of
> non-success
> --------------------------------------------------------------------------------
>
> Key: JENKINS-12881
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12881
> Project: Jenkins
> Issue Type: New Feature
> Components: gerrit-trigger
> Affects Versions: current
> Reporter: Joe Hansche
> Assignee: rsandell
> Labels: gerrit
>
> Some background is discussed here:
> https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger?focusedCommentId=59508437#comment-59508437
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
