[ 
https://issues.jenkins-ci.org/browse/JENKINS-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159103#comment-159103
 ] 

kutzi commented on JENKINS-12046:
---------------------------------

I agree that the plugin should look for results if a build is a failure (not 
looking for them in that case was btw never requested in this issue)

I don't agree with looking for results in case of aborted builds. In the worst 
case an aborted build could leave broken, invalid result files which could let 
the reporter crash. Even in the best case that all results are written already, 
I don't see any good reason to parse them when the build is already aborted, as:

a) it takes unnecessary time (often I abort build, becuase I want the next 
build for theat job to start immediately)
b) the results are of no real value as the user doesn't know how many of all 
test have already been running. So deltas are of no value

Also, other reporters seem to do the same (can not speak for all obviously). 
See e.g. above in the log string:
"17:48:11 [WARNINGS] Skipping publisher since build result is ABORTED"
                
> TestNG shouldn't look for result files if build was aborted
> -----------------------------------------------------------
>
>                 Key: JENKINS-12046
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12046
>             Project: Jenkins
>          Issue Type: Improvement
>          Components: testng
>            Reporter: kutzi
>            Assignee: nalin_makar
>            Priority: Minor
>
> When the build was aborted the plugin still seems to scan the workspace for 
> TestNG result files.
> This is only a minor issue, but could save some time. See build log below 
> where we could have spared 50 seconds by this.
> 17:48:11  Build was aborted
> 17:48:11  [WARNINGS] Skipping publisher since build result is ABORTED
> 17:48:11  Archiving artifacts
> 17:48:11  ERROR: Ignore Problem expanding maven opts macros 
> org.jenkinsci.plugins.tokenmacro.TokenMacro
> 17:48:11  Checking console output
> 17:48:11  Looking for TestNG results report in workspace using pattern: 
> **/target/surefire-reports/**/testng-results.xml
> 17:49:08  [ci-game] evaluating rule: Build result
> 17:49:08  [ci-game] evaluating rule: Increased number of failed tests

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to