[ 
https://issues.jenkins-ci.org/browse/JENKINS-12692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158926#comment-158926
 ] 

bap commented on JENKINS-12692:
-------------------------------

It would appear that the dropdownDescriptorSelector is introducing another 
instance of the plugin view into the page even though the form elements are not 
visible in the page source (and the Warnings Publisher has not been selected). 
This means that the radio names and values are duplicated.

Changing the radios in health.jelly to the following will give the radios the 
expected behaviour.
{code:xml} 
<f:entry title="${%Health priorities}" 
description="${%description.health.priorities}">
  <j:invokeStatic var="pfx" className="java.lang.System" 
method="currentTimeMillis"/>
  <f:radio name="${pfx}.thresholdLimit" value="high" 
checked="${instance.thresholdLimit == 'high'}" title="${%Only priority high}"/>
  <f:radio name="${pfx}.thresholdLimit" value="normal" 
checked="${instance.thresholdLimit == 'normal'}" title="${%Priorities high and 
normal}"/>
  <f:radio name="${pfx}.thresholdLimit" value="low" checked="${(instance == 
null) ? 'true' : instance.thresholdLimit == 'low'}" title="${%All priorities}"/>
</f:entry>
{code}
The above would not be guaranteed to work (based on time), and a better 
approach would be to replace the pfx with a j:var which gets an increasing 
number from the descriptor. The number only needs to be unique during a single 
request.

                
> Plugin destroys configuration of Publishers
> -------------------------------------------
>
>                 Key: JENKINS-12692
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-12692
>             Project: Jenkins
>          Issue Type: Bug
>          Components: flexible-publish
>            Reporter: Ulli Hafner
>            Assignee: bap
>            Priority: Blocker
>
> After installing the flexible-publish plugin, the Publishers of some jobs get 
> corrupted on save. 
> E.g. I have a WarningsPublisher in my job with the following serialization:
> {code}
> <publishers>
>     <hudson.plugins.warnings.WarningsPublisher>
>       <healthy></healthy>
>       <unHealthy></unHealthy>
>       <pluginName>[WARNINGS] </pluginName>
>       <defaultEncoding></defaultEncoding>
>       <canRunOnFailed>false</canRunOnFailed>
>       <useDeltaValues>false</useDeltaValues>
>       <thresholds>
>         <unstableTotalAll></unstableTotalAll>
>         <unstableTotalHigh></unstableTotalHigh>
>         <unstableTotalNormal></unstableTotalNormal>
>         <unstableTotalLow></unstableTotalLow>
>         <failedTotalAll></failedTotalAll>
>         <failedTotalHigh></failedTotalHigh>
>         <failedTotalNormal></failedTotalNormal>
>         <failedTotalLow></failedTotalLow>
>       </thresholds>
>       <shouldDetectModules>false</shouldDetectModules>
>       <dontComputeNew>true</dontComputeNew>
>       <parserConfigurations/>
>       <consoleLogParsers>
>         <string>Java Compiler</string>
>       </consoleLogParsers>
>     </hudson.plugins.warnings.WarningsPublisher>
> {code}
> After installing the flexible-publish plug-in, I get the following result 
> when saving the configuration. Seems that there is an interaction between 
> these plug-ins.  
> {code}
> <publishers>
>     <hudson.plugins.warnings.WarningsPublisher>
>       <healthy></healthy>
>       <unHealthy></unHealthy>
>       <thresholdLimit>low</thresholdLimit>
>       <pluginName>[WARNINGS] </pluginName>
>       <defaultEncoding></defaultEncoding>
>       <canRunOnFailed>false</canRunOnFailed>
>       <useDeltaValues>false</useDeltaValues>
>       <thresholds>
>         <unstableTotalAll></unstableTotalAll>
>         <unstableTotalHigh></unstableTotalHigh>
>         <unstableTotalNormal></unstableTotalNormal>
>         <unstableTotalLow></unstableTotalLow>
>         <failedTotalAll></failedTotalAll>
>         <failedTotalHigh></failedTotalHigh>
>         <failedTotalNormal></failedTotalNormal>
>         <failedTotalLow></failedTotalLow>
>       </thresholds>
>       <shouldDetectModules>false</shouldDetectModules>
>       <dontComputeNew>true</dontComputeNew>
>       <parserConfigurations/>
>       <consoleLogParsers>
>         <string>Java Compiler</string>
>       </consoleLogParsers>
>     </hudson.plugins.warnings.WarningsPublisher>
> {code}
> The following tag is removed: 
> {code}
>  <thresholdLimit>low</thresholdLimit>
> {code}
> I have no idea what is causing that problem. Maybe the reason is something 
> deep in core or in my analysis plug-ins. I need to attach a debugger to our 
> server...
> Any ideas? What exactly is the flexible publisher doing in Jenkins core? Is 
> it intercepting the publishers somehow?
> Interestingly, the problem has been reported with another simpilar plug-ins 
> too: the template project. 
> Here some related issues: JENKINS-8185, JENKINS-12182.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to