Thanks, the pull request has been merged, and the commit has been backported to the stable branch.
A new RC is available at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.387.1-rc33315.3b_778b_3e1c8d/jenkins-war-2.387.1-rc33315.3b_778b_3e1c8d.war On Wednesday, 22 February 2023 at 19:11:31 UTC+1 [email protected] wrote: > Hey again, > > Here is a Pull Request providing a fix for the regression discussed above: > https://github.com/jenkinsci/jenkins/pull/7668 > > Let me know if anything else is needed :) > > On Wednesday, February 22, 2023 at 5:51:18 PM UTC+1 Antoine Neveux wrote: > >> Hello Alex, hello everyone, >> >> There is a regression introduced with that LTS version: [JENKINS-70662 >> <https://issues.jenkins.io/browse/JENKINS-70662>] Built-in validations >> are broken when inside an `optionalBlock`. >> >> The commit that led to this regression is >> 5870838f690eaa06762630eceb21c40d3df0ceb8 >> <https://github.com/jenkinsci/jenkins/commit/5870838f690eaa06762630eceb21c40d3df0ceb8>, >> >> coming from Pull Request: #7203 >> <https://github.com/jenkinsci/jenkins/pull/7203>. The regression was >> first delivered with Jenkins 2.376. >> >> The particular change that led to this regression is the submit button in >> form/submit.jelly which was changed from <input type="submit" to <button. >> >> The error which is faced (An invalid form control with name='' is not >> focusable) is likely a browser validation error (reference >> <https://stackoverflow.com/questions/22148080/an-invalid-form-control-with-name-is-not-focusable/28340579#28340579> >> ). >> >> Different solutions could be imagined, among some tested: >> >> - Adding novalidate="true" to the form tag in form.jelly works, with >> a concern about f:form being sufficiently commonly used to be a valid >> approach? >> - Adding formNoValidate="true" to the submit button works as well >> >> Other solutions could be considered, but might be more difficult to put >> in place? >> >> I'm not familiar with how OSS LTS releases are managed, so could you >> please let me know how we could move forward with that concern? Would you >> like me to submit a Pull Request to core with one of these fixes? >> >> Thanks a lot for your help and attention, have a great day! >> >> Antoine >> >> On Wednesday, February 22, 2023 at 10:06:51 AM UTC+1 [email protected] >> wrote: >> >>> Hello everyone, >>> >>> Latest LTS RC was made public, and it is ready to be tested. Final >>> release is scheduled for 2023-03-08. >>> >>> Please report your findings in this thread. >>> >>> Download the release from: >>> https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/main/jenkins-war/2.387.1-rc33314.b_f418c7c9f79/jenkins-war-2.387.1-rc33314.b_f418c7c9f79.war >>> Best regards, >>> Alex >>> >> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d8a2d903-262b-4c03-bd36-c18bb9f8e7a5n%40googlegroups.com.
