On Sun, Jan 29, 2023 at 8:53 PM Basil Crow <m...@basilcrow.com> wrote:
> By the same logic, we could dispense with core PR reviews because any > commit can be reverted without problems. Such an approach would appear > to go against the consensus-driven nature of the project. > If there were votes taken for release readiness, rather than a weekly release train that ships whatever is on the default branch, maybe. As it is, it's not a good comparison. I also see this less as a step to remove maintainers who are not doing any maintenance (which goes beyond what the officers' mission is) and more limiting risk (which is in scope). IMO if one of the affected folks were to show up tomorrow and resume activity in core reviews etc., I would be happy with a quick restoration of access, different from how it'd work for a newcomer. Similarly, if any of the folks affected actually did have recent activity and it was just missed, access can easily be restored as well with minimal inconvenience to those affected. That would make those people eligible to be members of the > core-pr-reviewers team, which has triage permissions but not write > permissions. Eligible members of the core team, which has write > permissions, would be those who have merged or closed a PR during the > last year. Can you see a flaw in my reasoning? > There's a discussion to be had about what activities count as core maintainer activities. While that's probably useful for us to have at some point, it'd block removing access from folks who _clearly_ are no longer involved. If Wadeck and Damien had removed or downgraded permissions of folks who're still actively submitting or reviewing PRs (perhaps just not clicking the "Merge" button), I could see the problems with this approach, as we've never defined what counts as maintaining. As is, arguments seem to be more about a hypothetical "what if" than what was actually done. How would you feel if any of the folks Oleg listed suddenly started to merge or close PRs? Would you really not be surprised, and "think this is fine"? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtKmJwL8U%2BjFbaWPKPV5uRGoVvH8QkhA8Wo_sZEjpVn%2BtQ%40mail.gmail.com.
