There was about 3 or 4 issues all around null checking and try-with-resouces at the time I migrated. They may all have been probably are all fixed now, but if you keep up to date with the parent pom you are probably also likely to keep up to date with the Jenkins version, so this would affect plugins that have less active development more, which means users are probably less familiar with our tooling to begin with and so a more stable build env would be an aid in these circumstances.
Maybe worth trying in a PR to a few older plugins. My concern may be invalid, I may have just been unlucky /James On Wed, 30 Nov 2022, 03:47 Basil Crow, <[email protected]> wrote: > On Tue, Nov 29, 2022 at 3:19 PM James Nord <[email protected]> wrote: > > > > This bytecode difference trips up spotbugs (causing several new false > positives) that have no option other than to be suppressed, so this change > will likely cause "unrelated" build failures somewhere. > > https://github.com/spotbugs/spotbugs/issues/756 presumably. That is > fixed in recent versions of SpotBugs (adopted in recent versions of > the plugin parent POM), so it should only be an issue for plugins with > an out-of-date build toolchain. > > For what it's worth, JEP-229 CD builds are already running with Java > 11 but `-release 8` and this has not caused any major problems. I do > not feel strongly and could go either way. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqhkNyfL5NiHs%2BM5UmHQsN12eovcnj_%2Br59mtcm2WxT5w%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPzq3pfKYiZhZkKo9p1CG4gkMRqfELP1YT8uCrr4qEhtcPLdcw%40mail.gmail.com.
