I've switched it to pr-head for a trial run. (Core and Tools folders only) Jesse has been advocating it for over 4 years now. Let's give it a go.
Easy to revert back if we find pr-merge was better On Wednesday, 6 July 2022 at 18:44:38 UTC+1 Jesse Glick wrote: > On Sun, Jul 3, 2022 at 5:13 AM Alexander Brandes <mc.ca...@gmail.com> > wrote: > >> Maybe I'm missing something, but I can see downsides only for this >> [PR-merge] strategy >> > > The upside is that the commit status will reflect whether the PR would > allow trunk to continue passing if it were merged *now*. With the simpler > PR-head strategy, a PR might pass in its original form, and have no textual > merge conflicts (edits within ~3 lines) yet actually be broken relative to > the current trunk. Thus by merging it you might inadvertently break trunk, > which would be disruptive. > > In practice this is not a very common problem, and the downsides are very > real, so I recommend switching to PR-head: > https://github.com/jenkins-infra/helpdesk/issues/1355 > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/64510df1-dc57-4185-ab1a-1a080d9f9c8fn%40googlegroups.com.
