TL;DR keep the alpha's to throw-away instances until I identify whether I need to rename classes before the beta
On Sun 25 Jun 2017 at 09:20, Stephen Connolly < [email protected]> wrote: > I have found an issue with how these plugins get their pipeline snippets > generated when all are installed an the same instance at the same time. > > Hopefully this is just a bug in the structs plugin and I can fix it > there... > > BUT if I cannot fix it in structs I WILL HAVE TO RENAME CLASSES before a > beta release. > > If I have to rename classes you will not be able to upgrade from -alpha to > -beta or GA as I cannot have the old classes present (but I will see if I > can find a way around) > > On Fri 23 Jun 2017 at 18:14, Mark Waite <[email protected]> wrote: > >> On Fri, Jun 23, 2017 at 10:37 AM Jesse Glick <[email protected]> >> wrote: >> >>> On Thu, Jun 22, 2017 at 8:02 PM, Mark Waite <[email protected]> >>> wrote: >>> > The git client plugin has tests which assume its branches are full >>> clones. >>> > It uses that assumption to reduce the setup time for submodule tests, >>> tests >>> > of tagging, and more. >>> >>> Wait, what? It is assuming that the tests are running in a >>> particularly configured checkout of the `git-client-plugin` >>> repository? That is certainly an antipattern. Tests should not even >>> assume that they are running in a Git checkout at all. Could just have >>> been a `cp -ar` from a source tree. Definitely worth cleaning this up >>> if I am understanding correctly what you are saying. >>> >>> >> I'm not sure I'd call it a "particularly configured checkout" since I >> generally consider "checkout" to be the results of a "git checkout", though >> I guess that is one way to describe it. >> >> Some of the current tests assume that the working repository is an >> accurate clone of the upstream repository from which it was cloned, >> including tags and remote branches (like tests/getSubmodules). It was an >> easy way to test submodules, remote clones, and authentication, without >> having to construct repositories containing specific tags and submodules >> each time. >> >> Since it is an anti-pattern, I'll plan to systematically replace those >> dependencies with similar conditions constructed from within the tests >> themselves. >> >> Thanks, >> Mark Waite >> >> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1hQ%2B2po6fcoM-ba72GKat6uCng0xspFDWr3n9f5RK6EQ%40mail.gmail.com >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEtuUVcXG8q3WtZNMAA%3D-zr6DPnKDhVvCVewmrksS8Mew%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEtuUVcXG8q3WtZNMAA%3D-zr6DPnKDhVvCVewmrksS8Mew%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > Sent from my phone > -- Sent from my phone -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMziWQft8aC7F2v93EwrTpJ8N%3DiznGcOowgLTq4S9EytLA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
