I submitted the experimental change here:

  
https://github.com/jenkinsci/p4-plugin/commit/ce55b6cfa989373d9cdf8421d102306a21bab88b

P4Groovy is the main object passed back to the user with GetP4Step and 
GetP4Task wrapping it up.  P4Groovy calls out to the Perforce API, which has a 
callback for message handling. 

The code seems to work and unit tests pass, the original error seems to be 
related to the assertBuildStatusSuccess() method and some other internal 
serialisation of the console data.

Any feedback on the code would be appreciated, especially if there is a simpler 
way to achieve the same result.

Kind regards,
Paul

> On 31 Aug 2016, at 20:11, Jesse Glick <[email protected]> wrote:
> 
> On Wed, Aug 31, 2016 at 10:52 AM, Paul Allen <[email protected]> wrote:
>> I was passing TaskListener to allow logging/reporting in the Console Output. 
>>  Is there a static method I can call instead?
> 
> No.
> 
>> My code gets invoked by FileCallable<>:
>>        T invoke(File f, VirtualChannel channel) throws IOException, 
>> InterruptedException;
> 
> How is this related to the creation of a Groovy extension, which I
> presume has something to do with Pipeline?
> 
> I feel like you are doing something too “creative” and getting derailed.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3zyS23M%3D7P2%2BSAoUJca1Vk0MhKUE%3DHWLkZV-ux-M%3DKwA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

<p style"color: gray;font-size: 10pt;font-family: arial, helvetica, 
sans-serif;">
--------------------------------------------------------------------------------
This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed. If
you have received this email in error please notify the system manager. Please
note that any views or opinions presented in this email are solely those of the
author and do not necessarily represent those of Perforce Software. Finally,
the recipient should check this email and any attachments for the presence of
viruses. Perforce Software accepts no liability for any damage caused by any
virus transmitted by this email.

Perforce Software UK Ltd is registered in England and Wales as company no.
3816019 at the following address: West Forest Gate, Wellington Road, Wokingham,
RG40 2AQ, UK
--------------------------------------------------------------------------------
</p>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/68BE83DF-3B81-4599-9BBB-3A659EB3D1CF%40perforce.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to