Branch: refs/heads/master
Home: https://github.com/jenkinsci/pipeline-model-definition-plugin
Commit: 4a5ed4909c29b9cac431f4f5fe56d730bd481c07
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/4a5ed4909c29b9cac431f4f5fe56d730bd481c07
Author: Andrew Bayer <andrew.ba...@gmail.com>
Date: 2017-08-17 (Thu, 17 Aug 2017)
Changed paths:
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
Log Message:
-----------
Tweak invalidWrapperType tests
Sometimes, when multiple tests are being run and...some other
condition applies (haven't figured out what, since I can't reproduce
it locally), the TestExtension in MultipleUnnamedParametersTest ends
up being present in other tests, most notably ErrorsEndpointOpsTest
and ErrorsJSONParserTest. Since we have to hardcode the expected error
in those tests, without it being calculated at the moment the test's
running, like ValidatorTest#invalidWrapperType, this can result in
failures where the list of valid options the test is expecting to see
is calculated before the TestExtension is added but the actual error
message is generated afterwards and so includes the TestExtension.
Since we have the full check including the list of valid types in
ValidatorTest, we might as well simplify the invalidWrapperType tests
elsewhere by using a shorter and consistent expected error string.
Commit: 836e7a7c6f5b6740e5f0339d87a831550a08d928
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/836e7a7c6f5b6740e5f0339d87a831550a08d928
Author: Robert Sandell <rsand...@cloudbees.com>
Date: 2017-08-17 (Thu, 17 Aug 2017)
Changed paths:
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
Log Message:
-----------
Merge pull request #183 from abayer/invalidwrappertype-test-cleanup
Tweak invalidWrapperType tests
Compare:
https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/62a5696a4509...836e7a7c6f5b
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
