Branch: refs/heads/master
Home: https://github.com/jenkinsci/pipeline-model-definition-plugin
Commit: aa49119dbc0c9e94c8f1b143fbf41d5fc1e436f4
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/aa49119dbc0c9e94c8f1b143fbf41d5fc1e436f4
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Environment.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/EnvironmentTest.java
A
pipeline-model-definition/src/test/resources/environmentCrossReferences.groovy
Log Message:
-----------
[FIXED JENKINS-41748] Handle env var cross references properly
This changes things to now properly expand environment variable names
referred to in `environment` values, building from the job context's
environment to the parent context (if per-stage `environment`) and
lastly to the immediate `environment` context.
This is not exactly *perfect*, per se - you still need to either
single quote or escape the dollar sign due to the `GString` getting
resolved before we can populate anything. May revisit that in the
future to see if there's a workaround we can use.
Commit: 8c45758ddd316310737fcea6f997f8cc5a708991
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/8c45758ddd316310737fcea6f997f8cc5a708991
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M pipeline-model-definition/pom.xml
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/EnvironmentTest.java
A
pipeline-model-definition/src/test/resources/environmentWithWorkspace.groovy
Log Message:
-----------
[FIXED JENKINS-41890] Resolve env after agent
This is to make sure we have `WORKSPACE` in the environment. Note that
this won't quite work right for per-stage agent/environment, though -
`WORKSPACE` there will still refer to the top-level `WORKSPACE` (if
there is one) or be null if `agent none` is used at the top
level. This is so that we have the per-stage environment populated
before evaluating any when condition, while not launching in a
per-stage agent until said when condition has already been
evaluated. Might reconsider this in the future.
Also added `.logMatches(String... patterns)` to
`AbstractModelDefTest.ExpectationsBuilder` so that we can do regular
expression matching against logs, which we needed to verify this.
Commit: 36f67e355e5ad777e75eab053004f954f1f27a01
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/36f67e355e5ad777e75eab053004f954f1f27a01
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/EnvironmentTest.java
M
pipeline-model-definition/src/test/resources/environmentCrossReferences.groovy
Log Message:
-----------
Rework environment translation entirely
Now we can do `"${FOO}bar"` and `"${params.SOMETHING ?: 'something-else'}"`,
but we can only do this thanks to some weird black magic, no longer
doing runtime translation for environment blocks and instead pulling
it from the ModelAST directly.
I don't love it. It's hackish. There's additional hackery involved in
`script.evaluate`ing to get the more complicated expressions to
resolve as well.
Commit: ae73b00e61a5d19bb3d35d7ef3e9872f5f01bfba
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/ae73b00e61a5d19bb3d35d7ef3e9872f5f01bfba
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy
M
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapper.java
Log Message:
-----------
Had to special case credentials further. Joy.
Commit: 7ed9ce61edd78bc5a818d48792a2a9e18a76d258
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/7ed9ce61edd78bc5a818d48792a2a9e18a76d258
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTEnvironment.java
A
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTEnvironmentValue.java
A
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTInternalFunctionCall.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTValue.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidator.java
M pipeline-model-api/src/main/resources/ast-schema.json
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java
R pipeline-model-definition/src/test/resources/credentials/mixedEnv.groovy
R pipeline-model-definition/src/test/resources/credentials/noBinding.groovy
R
pipeline-model-definition/src/test/resources/credentials/usernamePassword.groovy
A pipeline-model-definition/src/test/resources/json/usernamePassword.json
A pipeline-model-definition/src/test/resources/mixedEnv.groovy
A pipeline-model-definition/src/test/resources/noBinding.groovy
A pipeline-model-definition/src/test/resources/usernamePassword.groovy
Log Message:
-----------
Internal function call handled separately in AST
Still gotta add negative-case tests, and will probably end up folding
JENKINS-41759 into this effort at some point, since that's where this
will *really* start to be valuable.
Commit: d2622fcd6a49722be8affcd4fcc4adff30da2b9b
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/d2622fcd6a49722be8affcd4fcc4adff30da2b9b
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
Log Message:
-----------
Begone, foul debug statement!
Commit: 7c075e63fc62d120a610874e08fa0d45a9ad91f5
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/7c075e63fc62d120a610874e08fa0d45a9ad91f5
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M pipeline-model-api/src/main/resources/ast-schema.json
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ExecuteConvertedTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java
Log Message:
-----------
Fix tests.
Commit: dc31b060455cff27d480af4c7d4955c998bb42cc
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/dc31b060455cff27d480af4c7d4955c998bb42cc
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
A
pipeline-model-definition/src/test/resources/json/environmentCrossReferences.json
Log Message:
-----------
Make sure JSON conversion works for env cross references
Commit: ad916f4e2f20eb8a4550c4270c042d658279d2af
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/ad916f4e2f20eb8a4550c4270c042d658279d2af
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTEnvironmentValue.java
M
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapper.java
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties
Log Message:
-----------
Review comments
Commit: f337baafc1b80c1a379921e576870c957d01ca59
https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/f337baafc1b80c1a379921e576870c957d01ca59
Author: Andrew Bayer <[email protected]>
Date: 2017-03-13 (Mon, 13 Mar 2017)
Changed paths:
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTEnvironment.java
A
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTEnvironmentValue.java
A
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTInternalFunctionCall.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/ast/ModelASTValue.java
M
pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidator.java
M pipeline-model-api/src/main/resources/ast-schema.json
M pipeline-model-definition/pom.xml
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Environment.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Root.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/model/Stage.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/JSONParser.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
M
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
M
pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapper.java
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ClosureModelTranslator.groovy
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties
M
pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/ModelInterpreter.groovy
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/AbstractModelDefTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/EnvironmentTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ExecuteConvertedTest.java
M
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/steps/CredentialWrapperStepTest.java
R pipeline-model-definition/src/test/resources/credentials/mixedEnv.groovy
R pipeline-model-definition/src/test/resources/credentials/noBinding.groovy
R
pipeline-model-definition/src/test/resources/credentials/usernamePassword.groovy
A
pipeline-model-definition/src/test/resources/environmentCrossReferences.groovy
A
pipeline-model-definition/src/test/resources/environmentWithWorkspace.groovy
A
pipeline-model-definition/src/test/resources/json/environmentCrossReferences.json
A pipeline-model-definition/src/test/resources/json/usernamePassword.json
A pipeline-model-definition/src/test/resources/mixedEnv.groovy
A pipeline-model-definition/src/test/resources/noBinding.groovy
A pipeline-model-definition/src/test/resources/usernamePassword.groovy
Log Message:
-----------
Merge pull request #110 from abayer/jenkins-41748
JENKINS-41748, JENKINS-41890 - Fix env var references and WORKSPACE
Compare:
https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/3cf9c0e15f13...f337baafc1b8
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
