Branch: refs/heads/master Home: https://github.com/jenkinsci/pipeline-model-definition-plugin Commit: a632cc6ab24f42498d3827af5db4abe017a0c0b0 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/a632cc6ab24f42498d3827af5db4abe017a0c0b0 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-01-24 (Tue, 24 Jan 2017)
Changed paths: M pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/options/impl/SkipDefaultCheckout.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java M pipeline-model-definition/src/test/resources/multipleProperties.groovy Log Message: ----------- [FIXED JENKINS-41391] Switch skipDefaultCheckout to default true That is - make skipDefaultCheckout() work the same as skipDefaultCheckout(true). Commit: 510b8c596d05714c2f045ff63e4f67eaee82fd82 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/510b8c596d05714c2f045ff63e4f67eaee82fd82 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy M pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/options/impl/SkipDefaultCheckout.java M pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java A pipeline-model-definition/src/test/resources/errors/duplicateOptionAndTriggerNames.groovy A pipeline-model-definition/src/test/resources/skipCheckoutFalse.groovy Log Message: ----------- Reject duplicate option/trigger names (i.e., types) Since we don't actually have any reasonable expectation of how it would work if you specify duplicates of a type in either options or triggers (their cousin, parameters, does expect/allow type duplication), we're going to just reject that if you try it. Also made changes to SkipDefaultCheckout and ModelValidatorImpl to allow validation to pass for "foo()" where foo's constructor has one and exactly one required argument, passing null instead - standard Groovy behavior that we should emulate for consistency. Commit: 052ce332f716bd475259d7bff586b4bfb0549b13 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/052ce332f716bd475259d7bff586b4bfb0549b13 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-01-24 (Tue, 24 Jan 2017) Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy Log Message: ----------- Narrowing down to only allow foo() for single-Boolean-parameter Got too risky with String and others, IMO. Commit: 6a59b744eec8b8c502a1a8d9a7944c48a1cbeb48 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/6a59b744eec8b8c502a1a8d9a7944c48a1cbeb48 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-01-25 (Wed, 25 Jan 2017) Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy Log Message: ----------- Changed from TODO to a note. Commit: a137932c11e920043213da753ec13b5b49914011 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/a137932c11e920043213da753ec13b5b49914011 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-01-25 (Wed, 25 Jan 2017) Changed paths: M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy M pipeline-model-definition/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/options/impl/SkipDefaultCheckout.java M pipeline-model-definition/src/main/resources/org/jenkinsci/plugins/pipeline/modeldefinition/Messages.properties M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/OptionsTest.java M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java A pipeline-model-definition/src/test/resources/errors/duplicateOptionAndTriggerNames.groovy M pipeline-model-definition/src/test/resources/multipleProperties.groovy A pipeline-model-definition/src/test/resources/skipCheckoutFalse.groovy Log Message: ----------- Merge pull request #100 from abayer/jenkins-41391 [FIXED JENKINS-41391] Switch skipDefaultCheckout to default true Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/a8bc15a55ac1...a137932c11e9 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.