Branch: refs/heads/master
Home: https://github.com/jenkinsci/github-oauth-plugin
Commit: d6bc0211b9627ecdc6687e34d97483146d06eff5
https://github.com/jenkinsci/github-oauth-plugin/commit/d6bc0211b9627ecdc6687e34d97483146d06eff5
Author: Dominic Scheirlinck <[email protected]>
Date: 2016-05-25 (Wed, 25 May 2016)
Changed paths:
M src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
Log Message:
-----------
[JENKINS-34775] Don't cast inconvertible un/pw token
Fixes JENKINS-34775.
The loadUserByUsername method expects to be able to get the current
user's token with
`SecurityContextHolder.getContext().getAuthentication()`, and assumes
this method will return a GithubAuthenticationToken. When it returns a
UserPasswordAuthenticationToken instead, a fatal cast was performed.
We now handle the case where the current authentication context contains
a UserPasswordAuthenticationToken (by throwing an exception - so, not
successfully handled, but this prevents the loadUserByUsername failure
bubbling up to become a job failure).
Commit: 986d98e7698b968eaa09270e57223312fb1aaa56
https://github.com/jenkinsci/github-oauth-plugin/commit/986d98e7698b968eaa09270e57223312fb1aaa56
Author: Sam Gleske <[email protected]>
Date: 2016-05-26 (Thu, 26 May 2016)
Changed paths:
M src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java
Log Message:
-----------
Merge PR #56 [JENKINS-34775] Don't cast
inconvertible un/pw token
Compare:
https://github.com/jenkinsci/github-oauth-plugin/compare/c21013f3341e...986d98e7698b
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
