Branch: refs/heads/master
Home: https://github.com/jenkinsci/durable-task-plugin
Commit: d156ebfbcdb70666757ff48127d0597bd5891a61
https://github.com/jenkinsci/durable-task-plugin/commit/d156ebfbcdb70666757ff48127d0597bd5891a61
Author: James Nord <[email protected]>
Date: 2016-05-19 (Thu, 19 May 2016)
Changed paths:
M src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
Log Message:
-----------
[JENKINS-34150] Fixes my observed issue.
I have a reproducable tests case in a propratary implementation using this
code that is 100% reproducable.
The simple "@echo off" fixes the failing test for me.
It seems that in the case that the parent process has been killed (e.g.
the slave dies) then all though the script terminates successfully and the
wrapper terminates successfully (checked with process monitor) there is no
attempt to create the result file.
where the parent process has not been killed I never see this issue.
All I needed to do to fix the issue I was observing is add @echo off as
the first line of the wrapper script. Basically I believe it is trying to
echo the commands to be run before running the commands and as there is no
longer anything consuming the wrappers input/output when echoing the
command it is doomed to fail (but strangely not with an exit code that
implies something died!??!
Commit: 8a2537cf28c826ad91d4ce14cd657712364c8953
https://github.com/jenkinsci/durable-task-plugin/commit/8a2537cf28c826ad91d4ce14cd657712364c8953
Author: Jesse Glick <[email protected]>
Date: 2016-05-19 (Thu, 19 May 2016)
Changed paths:
M src/main/java/org/jenkinsci/plugins/durabletask/WindowsBatchScript.java
Log Message:
-----------
Merge pull request #24 from jtnord/jenkins-34150
[FIXED JENKINS-34150] Fixes my observed issue.
Compare:
https://github.com/jenkinsci/durable-task-plugin/compare/0f09bb54a1b7...8a2537cf28c8
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
