Branch: refs/heads/master Home: https://github.com/jenkinsci/jenkins Commit: e4b1aab4acab93d638624c7705cfe6eea2d01786 https://github.com/jenkinsci/jenkins/commit/e4b1aab4acab93d638624c7705cfe6eea2d01786 Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-20 (Tue, 20 Oct 2015)
Changed paths: M changelog.html M core/src/main/java/hudson/model/Computer.java M core/src/main/java/hudson/model/Node.java M core/src/main/java/jenkins/model/Jenkins.java M core/src/main/java/jenkins/model/Nodes.java Log Message: ----------- [FIXED JENKINS-31055] Make Node implement Saveable - Also tidy up some of the mess logic in both #1866 and #1860 Commit: 8645978bfbe272a494d2bc65cf47104255cfb3fb https://github.com/jenkinsci/jenkins/commit/8645978bfbe272a494d2bc65cf47104255cfb3fb Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-21 (Wed, 21 Oct 2015) Changed paths: M core/src/main/java/jenkins/model/Nodes.java Log Message: ----------- [JENKINS-31055] Finessing the exception handling Commit: db37c76327748261c3b01eebd13369a1ca733282 https://github.com/jenkinsci/jenkins/commit/db37c76327748261c3b01eebd13369a1ca733282 Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-21 (Wed, 21 Oct 2015) Changed paths: M core/src/main/java/hudson/model/Node.java Log Message: ----------- [JENKINS-31055] Replacing @since tag with placeholder to be restored on merge Commit: 8e24f69013e96e8b7f8b86e9b7a9133e2412c638 https://github.com/jenkinsci/jenkins/commit/8e24f69013e96e8b7f8b86e9b7a9133e2412c638 Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-21 (Wed, 21 Oct 2015) Changed paths: M core/src/main/java/hudson/model/Node.java Log Message: ----------- [JENKINS-31055] The intent of Node.save() is a no-op when not in Jenkins list of nodes Commit: d2276c3c9b16fd46a3912ab8d58c418e67d8ce3e https://github.com/jenkinsci/jenkins/commit/d2276c3c9b16fd46a3912ab8d58c418e67d8ce3e Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-21 (Wed, 21 Oct 2015) Changed paths: M core/src/main/java/jenkins/model/Nodes.java Log Message: ----------- [JENKINS-31055] Note theoretical race condtion Seems rather unlikely, but none the less it is a possibility. Not sure how we should handle this though: * We do not want to hold the Queue lock while performing I/O as that will grind everything to a halt * We do not want a big fat lock on all nodes * If we have a per-node lock then the save everything method may have to grab them all In short, it gets ugly real fast. For now, I believe that the risk is very low as releasing a lock does not intrinsically deschedule a currently running thread so the likely course of events is that the thread will release the lock and at least start the save before a competing thread could acquire the lock update remove the node release the lock and delete the node's directory Commit: 695fe6bf5dcea42cb1195c8c298c6a5df033a918 https://github.com/jenkinsci/jenkins/commit/695fe6bf5dcea42cb1195c8c298c6a5df033a918 Author: Stephen Connolly <stephen.alan.conno...@gmail.com> Date: 2015-10-23 (Fri, 23 Oct 2015) Changed paths: M changelog.html M core/src/main/java/hudson/model/Computer.java M core/src/main/java/hudson/model/Node.java M core/src/main/java/jenkins/model/Jenkins.java M core/src/main/java/jenkins/model/Nodes.java Log Message: ----------- Merge pull request #1877 from stephenc/jenkins-31055 [FIXED JENKINS-31055] Make Node implement Saveable Compare: https://github.com/jenkinsci/jenkins/compare/2d1d47edef3b...695fe6bf5dce -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.