Branch:
refs/heads/improve-error-handling-for-canonical-hostname-lookup-failures
Home: https://github.com/jenkinsci/swarm-plugin
Commit: bd1ba0478f124911087b2d27dbaa357020e0d299
https://github.com/jenkinsci/swarm-plugin/commit/bd1ba0478f124911087b2d27dbaa357020e0d299
Author: Peter Jönsson <p...@spotify.com>
Date: 2015-07-20 (Mon, 20 Jul 2015)
Changed paths:
M client/src/main/java/hudson/plugins/swarm/Client.java
Log Message:
-----------
Improve end user reporting of hostname lookup errors
The CanonicalHostName() method call is only best effors as stated in the
Java documentation:
"Gets the fully qualified domain name for this IP address. Best effort
method, meaning we may not be able to return the FQDN depending on
the underlying system configuration"
This means that we can experience failures if the system configuration
is such that when the swarm client is launched we can't determine our
hostname. Since swarm slaves are often spawned in public/private clouds
there might be some eventual consistency with regards to lookup of
hostnames. We try to help the situation by printing a somewhat
informative error message.
Using the '-name' command line option for this should have been a way to
work around this. However we where unconditionally performing this
lookup. Instead we now only perform the lookup of no name has been
provided on the command line.
Thanks to @jacob-keller who reported this.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
